Use Generated ResourceHelper for NodeJs Strings Used in Attributes#1384
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom Oct 24, 2016
Conversation
**Bug** Follow up on microsoft#1382. That PR changed most strings used in code to use the generated resource helper classes. It did not convert over strings that are used in attributes. **Fix** Move these strings over as well. The strings passed to attributes must be constant, so `nameof` is used to ensure the strings are strongly typed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Follow up on #1382. That PR changed most strings used in code to use the generated resource helper classes. It did not convert over strings that are used in attributes.
Fix
Change localizable strings used in attributes to use the generated resource helper as wells. The strings passed to attributes must be constant, so
nameofis used. This ensures the strings are strongly typed while also letting us get rid of mostSRentries.